Visual Studio Warnings

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Visual Studio Warnings

Aaron Boxer
FYI:

libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from 'int' to 'thandle_t' of greater size
\libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation from 'thandle_t' to 'int'
\libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation from 'thandle_t' to 'int'
\libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored: 'snprintf'.
\libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit value.  Results might not be an expected value.
\libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit value.  Results might not be an expected value.
\libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit value.  Results might not be an expected value.
\libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit value.  Results might not be an expected value.

The first three already have a FIXME comment.

I doubt these cause actual bugs, but always to be warning-free.

Cheers,
Aaron

_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Bob Friesenhahn
I assume that this was for a 64-bit build.  Most of these warnings
look suspect to me.  Anything involving computation of a pointer
address deserves close attention.

Please check if adding (size_t) to the shifted value like

   m = img->UaToAa+((size_t) a2<<8);

makes the warning go away for 32 and 64-bit builds.

The libtiff release is still "pending" but if all goes well I expect
that it will no longer be pending as of Saturday the 19th.

Bob

On Wed, 16 Nov 2016, Aaron Boxer wrote:

> FYI:
>
> libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from 'int'
> to 'thandle_t' of greater size
> \libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
> from 'thandle_t' to 'int'
> \libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
> from 'thandle_t' to 'int'
> \libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
> 'snprintf'.
> \libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
> \libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
> \libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
> \libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
>
> The first three already have a FIXME comment.
>
> I doubt these cause actual bugs, but always to be warning-free.
>
> Cheers,
> Aaron
>

--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Aaron Boxer
Thanks, Bob. Yes, 64 bit build. And yes, cast to size_t does fix the warning.
Aaron

On Thu, Nov 17, 2016 at 9:41 AM, Bob Friesenhahn <[hidden email]> wrote:
I assume that this was for a 64-bit build.  Most of these warnings look suspect to me.  Anything involving computation of a pointer address deserves close attention.

Please check if adding (size_t) to the shifted value like

  m = img->UaToAa+((size_t) a2<<8);

makes the warning go away for 32 and 64-bit builds.

The libtiff release is still "pending" but if all goes well I expect that it will no longer be pending as of Saturday the 19th.

Bob


On Wed, 16 Nov 2016, Aaron Boxer wrote:

FYI:

libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from 'int'
to 'thandle_t' of greater size
\libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
'snprintf'.
\libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.

The first three already have a FIXME comment.

I doubt these cause actual bugs, but always to be warning-free.

Cheers,
Aaron


--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/


_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Bob Friesenhahn
Aaron,

Please check again and verify that the warnings are reduced.

The warnings regarding 'thandle_t' are a known issue.  I suspect that
using 'tif_unix.c' rather than 'tif_win32.c' is more reliable into the
future under Windows (not knowing when 64-bit Windows will use handle
values beyond 32-bits) until the handle size problem is fixed.

Anyone with a useful libtiff test suite should be running it this week
in order to assure that there are no regressions in libtiff.

Bob

On Thu, 17 Nov 2016, Aaron Boxer wrote:

> Thanks, Bob. Yes, 64 bit build. And yes, cast to size_t does fix the
> warning.
> Aaron
>
> On Thu, Nov 17, 2016 at 9:41 AM, Bob Friesenhahn <
> [hidden email]> wrote:
>
>> I assume that this was for a 64-bit build.  Most of these warnings look
>> suspect to me.  Anything involving computation of a pointer address
>> deserves close attention.
>>
>> Please check if adding (size_t) to the shifted value like
>>
>>   m = img->UaToAa+((size_t) a2<<8);
>>
>> makes the warning go away for 32 and 64-bit builds.
>>
>> The libtiff release is still "pending" but if all goes well I expect that
>> it will no longer be pending as of Saturday the 19th.
>>
>> Bob
>>
>>
>> On Wed, 16 Nov 2016, Aaron Boxer wrote:
>>
>> FYI:
>>>
>>> libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from
>>> 'int'
>>> to 'thandle_t' of greater size
>>> \libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
>>> from 'thandle_t' to 'int'
>>> \libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
>>> from 'thandle_t' to 'int'
>>> \libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
>>> 'snprintf'.
>>> \libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
>>> value is shifted, then cast to 64-bit value.  Results might not be an
>>> expected value.
>>> \libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
>>> value is shifted, then cast to 64-bit value.  Results might not be an
>>> expected value.
>>> \libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
>>> value is shifted, then cast to 64-bit value.  Results might not be an
>>> expected value.
>>> \libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
>>> value is shifted, then cast to 64-bit value.  Results might not be an
>>> expected value.
>>>
>>> The first three already have a FIXME comment.
>>>
>>> I doubt these cause actual bugs, but always to be warning-free.
>>>
>>> Cheers,
>>> Aaron
>>>
>>>
>> --
>> Bob Friesenhahn
>> [hidden email], http://www.simplesystems.org/users/bfriesen/
>> GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
>>
>

--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Aaron Boxer
Thanks.
I've been getting my libtiff from this unofficial github mirror:

https://github.com/vadz/libtiff

Will have to wait to test until this repo gets updated with your latest check-ins.




On Thu, Nov 17, 2016 at 9:58 PM, Bob Friesenhahn <[hidden email]> wrote:
Aaron,

Please check again and verify that the warnings are reduced.

The warnings regarding 'thandle_t' are a known issue.  I suspect that using 'tif_unix.c' rather than 'tif_win32.c' is more reliable into the future under Windows (not knowing when 64-bit Windows will use handle values beyond 32-bits) until the handle size problem is fixed.

Anyone with a useful libtiff test suite should be running it this week in order to assure that there are no regressions in libtiff.

Bob


On Thu, 17 Nov 2016, Aaron Boxer wrote:
Thanks, Bob. Yes, 64 bit build. And yes, cast to size_t does fix the
warning.
Aaron

On Thu, Nov 17, 2016 at 9:41 AM, Bob Friesenhahn <
[hidden email]> wrote:

I assume that this was for a 64-bit build.  Most of these warnings look
suspect to me.  Anything involving computation of a pointer address
deserves close attention.

Please check if adding (size_t) to the shifted value like

  m = img->UaToAa+((size_t) a2<<8);

makes the warning go away for 32 and 64-bit builds.

The libtiff release is still "pending" but if all goes well I expect that
it will no longer be pending as of Saturday the 19th.

Bob


On Wed, 16 Nov 2016, Aaron Boxer wrote:

FYI:

libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from
'int'
to 'thandle_t' of greater size
\libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
'snprintf'.
\libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.

The first three already have a FIXME comment.

I doubt these cause actual bugs, but always to be warning-free.

Cheers,
Aaron


--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/



--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/


_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Aaron Boxer
Okey, dokey, the warnings are reduced. Thanks!
Aaron

On Thu, Nov 17, 2016 at 11:19 PM, Aaron Boxer <[hidden email]> wrote:
Thanks.
I've been getting my libtiff from this unofficial github mirror:

https://github.com/vadz/libtiff

Will have to wait to test until this repo gets updated with your latest check-ins.




On Thu, Nov 17, 2016 at 9:58 PM, Bob Friesenhahn <[hidden email]> wrote:
Aaron,

Please check again and verify that the warnings are reduced.

The warnings regarding 'thandle_t' are a known issue.  I suspect that using 'tif_unix.c' rather than 'tif_win32.c' is more reliable into the future under Windows (not knowing when 64-bit Windows will use handle values beyond 32-bits) until the handle size problem is fixed.

Anyone with a useful libtiff test suite should be running it this week in order to assure that there are no regressions in libtiff.

Bob


On Thu, 17 Nov 2016, Aaron Boxer wrote:
Thanks, Bob. Yes, 64 bit build. And yes, cast to size_t does fix the
warning.
Aaron

On Thu, Nov 17, 2016 at 9:41 AM, Bob Friesenhahn <
[hidden email]> wrote:

I assume that this was for a 64-bit build.  Most of these warnings look
suspect to me.  Anything involving computation of a pointer address
deserves close attention.

Please check if adding (size_t) to the shifted value like

  m = img->UaToAa+((size_t) a2<<8);

makes the warning go away for 32 and 64-bit builds.

The libtiff release is still "pending" but if all goes well I expect that
it will no longer be pending as of Saturday the 19th.

Bob


On Wed, 16 Nov 2016, Aaron Boxer wrote:

FYI:

libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from
'int'
to 'thandle_t' of greater size
\libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
'snprintf'.
\libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.

The first three already have a FIXME comment.

I doubt these cause actual bugs, but always to be warning-free.

Cheers,
Aaron


--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/



--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/



_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Aaron Boxer
By the way, I compiled that latest tifflib under linux 64 bit, gcc 5.4, and there are a number of warnings
about "format %llu expects long long unsigned int but argument 4 has type toff_t (aka long unsigned int) "

For example:


"Failed to read directory at offset " TIFF_UINT64_FORMAT,nextdiroff);

in

tiff_dirread.c




On Fri, Nov 18, 2016 at 10:37 AM, Aaron Boxer <[hidden email]> wrote:
Okey, dokey, the warnings are reduced. Thanks!
Aaron

On Thu, Nov 17, 2016 at 11:19 PM, Aaron Boxer <[hidden email]> wrote:
Thanks.
I've been getting my libtiff from this unofficial github mirror:

https://github.com/vadz/libtiff

Will have to wait to test until this repo gets updated with your latest check-ins.




On Thu, Nov 17, 2016 at 9:58 PM, Bob Friesenhahn <[hidden email]> wrote:
Aaron,

Please check again and verify that the warnings are reduced.

The warnings regarding 'thandle_t' are a known issue.  I suspect that using 'tif_unix.c' rather than 'tif_win32.c' is more reliable into the future under Windows (not knowing when 64-bit Windows will use handle values beyond 32-bits) until the handle size problem is fixed.

Anyone with a useful libtiff test suite should be running it this week in order to assure that there are no regressions in libtiff.

Bob


On Thu, 17 Nov 2016, Aaron Boxer wrote:
Thanks, Bob. Yes, 64 bit build. And yes, cast to size_t does fix the
warning.
Aaron

On Thu, Nov 17, 2016 at 9:41 AM, Bob Friesenhahn <
[hidden email]> wrote:

I assume that this was for a 64-bit build.  Most of these warnings look
suspect to me.  Anything involving computation of a pointer address
deserves close attention.

Please check if adding (size_t) to the shifted value like

  m = img->UaToAa+((size_t) a2<<8);

makes the warning go away for 32 and 64-bit builds.

The libtiff release is still "pending" but if all goes well I expect that
it will no longer be pending as of Saturday the 19th.

Bob


On Wed, 16 Nov 2016, Aaron Boxer wrote:

FYI:

libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from
'int'
to 'thandle_t' of greater size
\libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
from 'thandle_t' to 'int'
\libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
'snprintf'.
\libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.
\libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
value is shifted, then cast to 64-bit value.  Results might not be an
expected value.

The first three already have a FIXME comment.

I doubt these cause actual bugs, but always to be warning-free.

Cheers,
Aaron


--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/



--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/




_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Bob Friesenhahn
On Fri, 18 Nov 2016, Aaron Boxer wrote:

> By the way, I compiled that latest tifflib under linux 64 bit, gcc 5.4, and
> there are a number of warnings
> about "format %llu expects long long unsigned int but argument 4 has type
> toff_t (aka long unsigned int) "

I am not seeing these when using 'configure'.  What mechanism are you
using for building (cmake?) and what options were provided?

On a system matching your description, I am not seeing any warnings
from the compiler while doing a 'make distcheck' using a
configure-based build with clang 3.5.1 installed (also tests the
clang build).

Thanks,

Bob
--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Aaron Boxer
Hi Bob,
Yes, this is a cmake build, but I am using a custom cmake file.

https://github.com/GrokImageCompression/grok/blob/master/thirdparty/libtiff/CMakeLists.txt

I guess this is my problem, then :)

Aaron


On Sat, Nov 19, 2016 at 10:09 AM, Bob Friesenhahn <[hidden email]> wrote:
On Fri, 18 Nov 2016, Aaron Boxer wrote:

By the way, I compiled that latest tifflib under linux 64 bit, gcc 5.4, and
there are a number of warnings
about "format %llu expects long long unsigned int but argument 4 has type
toff_t (aka long unsigned int) "

I am not seeing these when using 'configure'.  What mechanism are you using for building (cmake?) and what options were provided?

On a system matching your description, I am not seeing any warnings from the compiler while doing a 'make distcheck' using a configure-based build with clang 3.5.1 installed (also tests the clang build).

Thanks,

Bob


_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Bob Friesenhahn
On Mon, 21 Nov 2016, Aaron Boxer wrote:

> Hi Bob,
> Yes, this is a cmake build, but I am using a custom cmake file.
>
> https://github.com/GrokImageCompression/grok/blob/master/thirdparty/libtiff/CMakeLists.txt
>
> I guess this is my problem, then :)

Your Cmake configuration is producing a wrong configuration value.  It
is as if it was partially configured on a 32-bit host.

>
> Aaron
>
>
> On Sat, Nov 19, 2016 at 10:09 AM, Bob Friesenhahn <
> [hidden email]> wrote:
>
>> On Fri, 18 Nov 2016, Aaron Boxer wrote:
>>
>> By the way, I compiled that latest tifflib under linux 64 bit, gcc 5.4, and
>>> there are a number of warnings
>>> about "format %llu expects long long unsigned int but argument 4 has type
>>> toff_t (aka long unsigned int) "
>>>
>>
>> I am not seeing these when using 'configure'.  What mechanism are you
>> using for building (cmake?) and what options were provided?
>>
>> On a system matching your description, I am not seeing any warnings from
>> the compiler while doing a 'make distcheck' using a configure-based build
>> with clang 3.5.1 installed (also tests the clang build).
>>
>> Thanks,
>>
>> Bob
>>
>> --
>> Bob Friesenhahn
>> [hidden email], http://www.simplesystems.org/users/bfriesen/
>> GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
>>
>

--
Bob Friesenhahn
[hidden email], http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

rleigh
In reply to this post by Aaron Boxer
On 21/11/16 18:57, Aaron Boxer wrote:
> Hi Bob,
> Yes, this is a cmake build, but I am using a custom cmake file.
>
> https://github.com/GrokImageCompression/grok/blob/master/thirdparty/libtiff/CMakeLists.txt
>
> I guess this is my problem, then :)

Out of interest, is there any deficiency in the provided CMake support
which prevents you using it?  I can see that your CMake code predates
the provided one by several years.  If there's any missing functionality
which you need, please let me know and I'll see what I can do.


Regards,
Roger
_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Visual Studio Warnings

Aaron Boxer
Thanks, Roger, I would love to use the provided cmake file, but haven't had time to port it
to my library. The cmake files I are using are the ones I inherited from OpenJPEG, with some small changes, for example
zip support.

Aaron

On Mon, Nov 21, 2016 at 2:44 PM, Roger Leigh <[hidden email]> wrote:
On 21/11/16 18:57, Aaron Boxer wrote:
> Hi Bob,
> Yes, this is a cmake build, but I am using a custom cmake file.
>
> https://github.com/GrokImageCompression/grok/blob/master/thirdparty/libtiff/CMakeLists.txt
>
> I guess this is my problem, then :)

Out of interest, is there any deficiency in the provided CMake support
which prevents you using it?  I can see that your CMake code predates
the provided one by several years.  If there's any missing functionality
which you need, please let me know and I'll see what I can do.


Regards,
Roger
_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/


_______________________________________________
Tiff mailing list: [hidden email]
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
Loading...